| Author |
Message |
|
shamzcc
|
Post subject: bug when printing inv Posted: Tue Jan 10, 2012 2:12 am |
|
Joined: Mon Nov 09, 2009 1:18 pm Posts: 296
|
|
hi dave i have another problem all this was working in previous version when printing an inv the sub total is the same as the total i.e the sub total is inclusive of vat ..
| Attachments: |

snapshot4.png [ 128.62 KiB | Viewed 283 times ]
|

snapshot3.png [ 205.56 KiB | Viewed 283 times ]
|
|
|
 |
|
 |
|
shamzcc
|
Post subject: Re: bug when printing inv Posted: Tue Jan 10, 2012 2:29 am |
|
Joined: Mon Nov 09, 2009 1:18 pm Posts: 296
|
|
line 160 of entry builder i changed from $this->invoice_subtotal += (1 + $line_tax) * $price; to $this->invoice_subtotal += $price;
|
|
 |
|
 |
|
ReneK
|
Post subject: Re: bug when printing inv Posted: Tue Jan 10, 2012 9:55 am |
|
Joined: Mon Mar 01, 2010 5:32 am Posts: 554 Location: Netherlands
|
|
@ dave Is already in the code.goolge issues number 70
_________________ Rene Kervezee
|
|
 |
|
 |
|
shamzcc
|
Post subject: Re: bug when printing inv Posted: Thu Jan 12, 2012 3:38 pm |
|
Joined: Mon Nov 09, 2009 1:18 pm Posts: 296
|
|
one more problem when printing the inv the extension per line includes tax ... thats wrong total per line must be qty times the unit price .. this was working 100% in 3.2 see the first attachment d3013m mattalic disc pads 5 63.16 = 315.80 but its displaying 360.01
|
|
 |
|
 |
|
ReneK
|
Post subject: Re: bug when printing inv Posted: Fri Jan 13, 2012 1:42 am |
|
Joined: Mon Mar 01, 2010 5:32 am Posts: 554 Location: Netherlands
|
|
Maybe we should modify it and add the line with tax to the table. Because if you sell only to customers then you would want to show price including tax. But if you sell to company's then you would want to show prices without tax.
_________________ Rene Kervezee
|
|
 |
|
 |
|
shamzcc
|
Post subject: Re: bug when printing inv Posted: Fri Jan 13, 2012 5:51 am |
|
Joined: Mon Nov 09, 2009 1:18 pm Posts: 296
|
|
@renek thats the correct way because u dont just sell to cash customers i mean the purpose for pb is wholesale and retail thats why we have pos and clients with terms .. the way it is now it doesnt even make sense to what u call customers or to companies ...
sku description qty unit total qty * unit= total
or
sku description qty unit total vat/tax grand total qty*unit=total+vat/tax=grand total
this is per line
|
|
 |
|
 |
|
shamzcc
|
Post subject: Re: bug when printing inv Posted: Fri Jan 13, 2012 6:37 am |
|
Joined: Mon Nov 09, 2009 1:18 pm Posts: 296
|
|
ok i hashed out line 155 // $line_tax = $this->taxes[$result->fields['taxable']]; and its working again but my question is whats the function of this line oh that’s in entry builder
|
|
 |
|
 |
|
ReneK
|
Post subject: Re: bug when printing inv Posted: Fri Jan 13, 2012 1:24 pm |
|
Joined: Mon Mar 01, 2010 5:32 am Posts: 554 Location: Netherlands
|
|
Maybe my choice of word is wrong that's probably because English isn't my first language. I meant retail and wholesale like you corrected. Thank you.
The point is in the pos module all transactions are paid immediately. These do not show up in your payments to receive. So is do allow a costumer to have credit ( he is allowed to pay in his own time.) then you need to make a invoice. So for these occasions you want to have a amount that in your output that has unit price with tax and line total with tax.
But is should also be possible to have unit price and line total without tax.
If these four items are then in the entery_builder maybe we could drop the look-a-like class in the pos module. This would may less maintenance.
_________________ Rene Kervezee
|
|
 |
|
 |
|
shamzcc
|
Post subject: Re: bug when printing inv Posted: Fri Jan 13, 2012 3:39 pm |
|
Joined: Mon Nov 09, 2009 1:18 pm Posts: 296
|
|
renek yip thats correct its good to have the possibilities i.e all four as you suggested .. and the user can then choose whether he wants tax inclusive or tax exclusive pricing to appear ... thankz bro !!!! this must be set in the company config.. maybe in modules General Settings configuration..
|
|
 |
|
 |
|
ReneK
|
Post subject: Re: bug when printing inv Posted: Sat Jan 14, 2012 8:34 am |
|
Joined: Mon Mar 01, 2010 5:32 am Posts: 554 Location: Netherlands
|
|
Well i was thinking about modifying it in the phreeform module. then company's that do both wholesale and retail can design there own forms.
_________________ Rene Kervezee
|
|
 |
|
 |
|
shamzcc
|
Post subject: Re: bug when printing inv Posted: Sat Jan 14, 2012 2:31 pm |
|
Joined: Mon Nov 09, 2009 1:18 pm Posts: 296
|
|
hmmm yip good idea too !! infect it will be better so the onus is left with the user to design the forms as per there own wish ok point noted renek.. thankz
|
|
 |
|
 |
|